
OpenPGP twice in services menu
Reported by Alex (via GPGTools) | August 5th, 2011 @ 12:27 AM
GPGServices: clean install on Lion OpenGPG: * twice for text (workaround: disable for files)
Version: 1.6
Steps that will reproduce the problem?
1. Install GPGServices on OS X Lion (clean installation or old
GPGServices already installed)
2. Enable the OpenPGP services for files
3. Open an OpenPGP/Inline encrypted message in Mail.app
4. Select the text and invoke the "OpenPGP:decrypt" services
menu
What is the expected result?
You should not be able to select the OpenPGP service menu since
we've not selected a file.
What happens instead?
Decryption fails silently (something about incomplete input
data).
Possible workaround:
Disable the OpenPGP services for files and enable the services for
text.
Any additional information:
The user should get some more feedback if s.th. fails.
Comments and changes to this ticket
-
ronin-140089 (at lighthouseapp) August 18th, 2011 @ 01:12 AM
- State changed from new to waiting
- Assigned user changed from ronin-140089 (at lighthouseapp) to Alex (via GPGTools)
Sounds like a problem with Mail.app to me. Can you send me a message where this bug appears?
(I'm not sure if it's fixable, though. The appearance of the menu item for decrypting files means that Mail.app says "I have a file for you, take a look")
-
Alex (via GPGTools) August 18th, 2011 @ 08:30 AM
- Assigned user cleared.
- Milestone cleared.
- Importance changed from to High
Can't reproduce it on my machine but I've seen it with my own eyes ;)
-
-
-
C Fraire March 3rd, 2012 @ 02:33 AM
- Assigned user set to Jeff burdges
When I was playing around with localizing GPGServices menu items text, I noticed that there are duplicated menu item names for the following:
"OpenPGP: Sign" for sign and signFile "OpenPGP: Encrypt" for encrypt and encryptFile "OpenPGP: Decrypt" for decrypt and decryptFile
The duplication makes it impossible to localize specifically for each operation (e.g., it cannot be "OpenPGP: Sign the Selection" and "OpenPGP: Sign the File" for sign and signFile, resp.).
It also explains how multiple, identically titled service options can appear if an app describes a selection with multiple possible NSSendTypes. I confirm this in TextMate, for example, if you open a new document, type "/tmp/sample.txt", and highlight it; the Services menu will have both sets of OpenPGP items, with "OpenPGP: Decrypt" (among others) duplicated.
Now one more weirdness, why isn't "OpenPGP: Encrypt" duplicated?
I think that is explained because decryptFile takes one more SendType than encryptFile:
encryptFile: NSFileNamesPboardType
decryptFile: NSFileNamesPboardType, public.plain-text -
C Fraire March 3rd, 2012 @ 02:33 AM
- Assigned user cleared.
-
C Fraire March 3rd, 2012 @ 02:33 AM
- Assigned user set to Jeff burdges
-
C Fraire March 3rd, 2012 @ 02:34 AM
- Assigned user cleared.
-
C Fraire May 23rd, 2012 @ 06:24 PM
- State changed from waiting to released
- Milestone cleared.
Version 1.7 had the updated Info.plist and ServiceMenu.strings.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
People watching this ticket
Attachments
Referenced by
-
101 Via Tender: BUG: GPG Services, duplicate context menu generation ... Btw: it's a duplicate: #81