
Add support for encryption
Reported by Alex (via GPGTools) | January 14th, 2011 @ 02:38 PM | in Q1 2011
Comments and changes to this ticket
-
-
Alex (via GPGTools) January 19th, 2011 @ 12:50 AM
- Title changed from Add support for encryption and decryption to Add support for encryption
-
Alex (via GPGTools) January 19th, 2011 @ 12:59 AM
- State changed from new to open
Implemented encryption. The missing part: a GUI to ask the user for a list of recipients.
-
Alex (via GPGTools) January 19th, 2011 @ 11:29 AM
- Assigned user changed from Kevin Holzer to Mento
Mento: maybe you could implement a very simple GUI? Should be very easy for you to implement the this pice. Have a look at https://github.com/GPGTools/GPGServices/blob/master/GPGServices.m#L140
-
-
-
Alex (via GPGTools) March 5th, 2011 @ 11:56 PM
- State changed from open to hold
First implementation from Moritz.
-
Alex (via GPGTools) March 6th, 2011 @ 12:05 AM
- Tag cleared.
Workflow: Encrypt text and chose the third/fourth/... key from the list
Result: "General Error" and Crash: "6 org.gpgtools.gpgservices 0x00002841 start + 53"
Information: no issues when choosing the first or second key -
ronin-140089 (at lighthouseapp) March 6th, 2011 @ 12:36 AM
Can reproduce it. Looks like it crashes when one of the selected keys isn't trusted. Two possible solutions: Set 'trustAllKeys' to 'YES' and ignore these keys, or hide keys whose trust-level isn't high enough.
I would go for the first (ignore the trust leven) while showing it in the ListView. Should be relative easy to implement.
-
Alex (via GPGTools) March 6th, 2011 @ 12:37 AM
Ack. You could also consider to add a warning if the trust level is too low - but I wouldn't recommend it.
-
Alex (via GPGTools) March 6th, 2011 @ 12:50 AM
Please enable "cmd+a" in the search field and cmd+f to enable it.
-
ronin-140089 (at lighthouseapp) March 6th, 2011 @ 01:41 AM
The application now accepts all keys for encryption and displays the trust level in a column in the table view. This should fix the crash.
Don't really know why Cmd-F and Cmd-A aren't working. I implemented a small hack to enable Cmd-F, but Cmd-A is more complicated (looks like we need a subclass of NSSearchPanel if we can't find the cause of the non-working key combinations).
-
Alex (via GPGTools) March 8th, 2011 @ 02:54 PM
- Assigned user changed from Alex (via GPGTools) to ronin-140089 (at lighthouseapp)
Thank you again. I've tested the latest version and integrated your changes to our repository.
- Cmd+A: maybe you could have a look at GPG Keychain Access. It's working there.
- Crash: it still crashes for me if the trust level is "Undefined" (according to your new colum
- List: nothing happens when I try to sort the list (click on the column head)
-
Alex (via GPGTools) March 8th, 2011 @ 03:21 PM
(from [edddecb64e084b82063e13065ea2008afc918a3b]) basically integrated Moritz' changes [#10] https://github.com/GPGTools/GPGServices/commit/edddecb64e084b82063e...
-
Alex (via GPGTools) March 8th, 2011 @ 04:17 PM
Ok, does not to work anymore when after compiling the sources in the GPGTools repository - could you please have a look at it?
-
ronin-140089 (at lighthouseapp) March 8th, 2011 @ 04:40 PM
You forgot many files in the commit you've linked, but fixed that in the following commit. Does it work now?
I can't test it because git clone --recursive doesn't work anymore. It fails with:
fatal: reference is not a tree: 4d1e288b79ff095818010a40deb0a856132a63a0 Unable to checkout '4d1e288b79ff095818010a40deb0a856132a63a0' in submodule path 'Dependencies/GPGTools_Core'
I don't have any experience with git-submodule, so I can't help there... sorry.
-
Alex (via GPGTools) March 8th, 2011 @ 05:39 PM
I can't test it because git clone --recursive doesn't work anymore. It fails with:
Mh, this is new. Fixed it.
You forgot many files in the commit you've linked, but fixed that in the following commit. Does it work now?
My current issue is that encrypting text doesn't show a window anymore and after a while the request is cancelled because GPGService did not provided an answer. Since a clean merge failed I tried to solve the issues manually - but now s.th. is broken :/
-
ronin-140089 (at lighthouseapp) March 8th, 2011 @ 06:10 PM
cloning worked fine now. Investigating...
-
Alex (via GPGTools) March 9th, 2011 @ 10:48 PM
Any success already? I would like to send a beta version around - encryption support is an amazing feature now ;)
-
ronin-140089 (at lighthouseapp) March 10th, 2011 @ 10:08 AM
I'm currently somewhat busy (the bad thing is called "Vorabi Klausur" ;)) but I try to do as much as I can.
Looks like I've got it now... (there were some merging errors)I'm not sure if I can fix it without access to the repository, but I'll write how to fix it:
The first thing missing is RecipientWindow.xib. Looks like the xcodeproject somehow lost that file. Drag 'RecipientWindow.xib' out of English.lproj/ to the desktop and from there drag it to the Xcode file explorer. Activate 'copy files' and add it to the target. This should copy the file to the bundle (it was missing).The second issue on my machine was the CFBundleExecutable in the Info.plist. My GPGServices.service was declared as invalid by the Finder because the value of 'CFBundleExecutable' didn't match the real executable name. The value from the new checkout was 'GPGServices.service' where it should have been 'GPGServices'. The latter was the value it had before the merge.
This is easily fixable too: Just open the Info.plist in Xcode and change the value of 'CFBundleExecutable' to 'GPGServices'.Save, clean the project, kill GPGServices in Activity Manager, build and you're good to go.
-
ronin-140089 (at lighthouseapp) March 10th, 2011 @ 10:13 AM
You can also try the attached patch:
git apply patchfile.diff
-
Alex (via GPGTools) March 10th, 2011 @ 10:46 AM
- State changed from hold to resolved
(from [29b6fa1b5b1dc531e28fe262a7d43f2e7652e43c]) applied patches to fix encryption window [#10 state:resolved] https://github.com/GPGTools/GPGServices/commit/29b6fa1b5b1dc531e28f...
-
Alex (via GPGTools) March 10th, 2011 @ 10:48 AM
Wow, thank you very much! The basic encryption works now (even though I found some other bugs in this context but I'll create new tickets for them). You're now officially part of the developer team: https://github.com/GPGTools/GPGTools/wiki/people
Have you managed to register to our developer mailing list?
-
Alex (via GPGTools) March 10th, 2011 @ 10:50 AM
Oh...and good luck with your exams. I hope you'll succeed and that you'll find some time to look at the other tickets later on.
-
steve June 18th, 2015 @ 04:23 PM
- State changed from resolved to released
- Importance cleared.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
People watching this ticket
Attachments
Referenced by
-
10 Add support for encryption (from [5c8a50bb52f52ed35ff0d23730bf6133ce8ba3b3]) added f...
-
10 Add support for encryption (from [edddecb64e084b82063e13065ea2008afc918a3b]) basical...
-
10 Add support for encryption (from [29b6fa1b5b1dc531e28fe262a7d43f2e7652e43c]) applied...