Encryption: crash when choosing an expired key
Reported by Alex (via GPGTools) | March 10th, 2011 @ 10:49 AM | in Q1 2011
Comments and changes to this ticket
-
Alex (via GPGTools) March 10th, 2011 @ 10:52 AM
- Tag set to “”
- State changed from “new” to “open”
-
Alex (via GPGTools) March 10th, 2011 @ 11:17 AM
- Tag cleared.
- Title changed from “Crash when choosing an expired key” to “Encryption: crash when choosing an expired key”
-
Alex (via GPGTools) March 16th, 2011 @ 09:08 PM
@Moritz: maybe you could also have a look at this one? I think expired keys should not be shown in the list (this is what GPGMail does, I think).
-
ronin-140089 (at lighthouseapp) March 16th, 2011 @ 11:39 PM
Crashes for expired and revoked keys. I'll have a look at it today or at least over the weekend (have to work tomorrow)
-
Alex (via GPGTools) March 17th, 2011 @ 01:33 PM
- Tag set to “”
- State changed from “open” to “hold”
- Assigned user changed from “ronin-140089 (at lighthouseapp)” to “Mento”
I have some methods for evaluating if a key is invalid:
hasKeyExpired
isKeyRevoked
hasKeyExpired
isKeyDisabledI'm not sure what the latest one does. Which of these methods should be used to validate a key? All of them?
-
Alex (via GPGTools) March 17th, 2011 @ 03:21 PM
- Tag cleared.
When in doubt I would consider all of the three methods.
-
ronin-140089 (at lighthouseapp) March 17th, 2011 @ 08:25 PM
Implemented in my fork.
Invalid keys aren't listed as possible recipients anymore. The list of recipients also gets stripped of invalid keys right before signing.
-
Alex (via GPGTools) March 17th, 2011 @ 08:36 PM
- Assigned user changed from “Mento” to “ronin-140089 (at lighthouseapp)”
Nice - thank you. Could you please test the following workflow:
- Select text
- Services > Encrypt
- Select all keys that are shown
- Encrypt
-
Alex (via GPGTools) March 17th, 2011 @ 08:38 PM
At least when I'm using the key 0x567C3C2DB804CF07 I'm getting a general error again.
-
ronin-140089 (at lighthouseapp) March 17th, 2011 @ 08:48 PM
I'll take a look at it.
It's very hard to test. There are so many things to consider when working with encryption and I'm not very experienced with the whole OpenPGP-thing ;-)
-
Alex (via GPGTools) March 17th, 2011 @ 08:55 PM
Thanks - you're doing a great job. Btw: The issue occurs when all subkeys are expired or revoked.
-
ronin-140089 (at lighthouseapp) March 17th, 2011 @ 08:59 PM
Looks like the issue with the key you mentioned is caused by the missing email on the default user-id. I can't use it for encryption on the command line either.
Does someone have a manual which describes what conditions a key has to satisfy to be valid for encryption?
-
-
ronin-140089 (at lighthouseapp) March 17th, 2011 @ 09:53 PM
Ha. Found the solution. It's so easy: http://macgpg.sourceforge.net/docs/GPGME-documentation/Classes/GPGK... canEncrypt
I'll implement it and test it on the problematic keys I have so far. Please send in other keys which could cause problems. -
ronin-140089 (at lighthouseapp) March 17th, 2011 @ 11:00 PM
Pushed it to my fork. Doesn't crash for 0x567C3C2DB804CF07 anymore. Should be pretty stable now :)
-
Alex (via GPGTools) March 17th, 2011 @ 11:56 PM
- State changed from “hold” to “resolved”
Nice! Works stable ;)
-
steve June 18th, 2015 @ 04:23 PM
- State changed from “resolved” to “released”
- Importance cleared.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
steve