#88 remove comment option from settings tab - GPGPreferences

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#88 ✓verified

remove comment option from settings tab

Reported by steve | December 15th, 2016 @ 10:33 AM | in 2.0.2b2 (closed)

In most cases use of the comment field does more harm than it does good. The comment field should only be used by expert users and those can as well create a comment via CLI.

We need to deal with two cases for existing users:

no comment in use → nothing
comment field in use → show dialog

Action task 1

Remove comment field from GPGPreferences > Settings

Action task 2

When GPGPreferences is first opened in the new version show following dialog:

Title: Important information about the comment field

Message: It appears you are using a comment. That is an expert option and best practices recommend not using the comment field at all since wrong usage may expose information to adversaries. To prevent this from happening, the comment field has been removed. We recommend to remove the comment. Only keep the comment if you really know what you are doing. Comments can be edited via command line in the future.

The comment you are currently using:

%&comment_here

Remove comment?

No Yes (yes pre-selected)

2017-01-16 update

Title: Important information about the comment field

Message: We have removed the option to set a comment in GPGPreferences. Best practices recommend to no longer use the comment field since wrong usage may leak information.

You have currently configured the following comment:

%&comment_here

Would you like to remove it?

No Yes (yes pre-selected)

Comments and changes to this ticket

Support January 13th, 2017 @ 03:29 PM
- State changed from “new” to “fixed”
- Assigned user set to “Mento”
- Milestone set to “2.0.2b2”
(from [501901d6269a38aa994dc9af6ae139afff138d68]) Remove comment field.

Ask user to remove existing comment.
[#88 state:fixed assigned:mento milestone:2.0.2] https://github.com/GPGTools/GPGPreferences/commit/501901d6269a38aa9...
steve January 16th, 2017 @ 07:24 PM
- State changed from “fixed” to “started”
In a brief test the dialog did not show.

Test on 10.12.2
1. installed GPG Suite 2016.10
2. added a comment in GPGPreferences and closed GPGPreferences
3. install GPG Suite 1745n
4. open GPGPreferences
Expected: when opening GPGPreferences the first time after this change and using a comment, the dialog should be shown.

Currently: no dialog show.

Setting this to started.

Text is updated (see initial bug above with updated date info)
Support January 17th, 2017 @ 01:49 PM
- State changed from “started” to “fixed”
(from [e951f3c821474d621b7aca679c2a84ea8c9c19cb]) Additional changes for last two commits.

[#88 state:fixed] [#89 state:fixed] https://github.com/GPGTools/GPGPreferences/commit/e951f3c821474d621...
steve January 18th, 2017 @ 05:50 PM
tested
1. installed GPG Suite 1747n
2. opened gpgp and changed comment to "test"
3. installed GPG Suite 1747n
4. open gpgp
expected: see dialog to remove comment

currently: nothing, comment stays in gpg.conf file

opening terminal and entering 'defaults delete org.gpgtools.gpgpreferences' then re-opening gpgp results in the expected dialog
steve January 19th, 2017 @ 11:04 AM
- State changed from “fixed” to “verified”
verified and expected. since this operation is a one-time event, flag needs to be removed for each test.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.