#120 check for key comment not executed, if called can lead to crash - GPGPreferences

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#120 ✓verified

check for key comment not executed, if called can lead to crash

Reported by steve | August 18th, 2021 @ 02:10 PM | in 2.6 (closed)

User report about GPG Suite Preferences from GPG Suite 3037n crashing on macOS Big Sur 11.5.2: https://gpgtools.tenderapp.com/discussions/nightly/2100

This seems to be the check for comment in a key.

Problems

check is not called on macOS Mojave or Big Sur when it should
check is not covering both https:// and http://
check can cause crash if called

Comments and changes to this ticket

Support August 18th, 2021 @ 02:10 PM
- Tag set to “”
Assigned to Tender discussion #2100.
steve August 18th, 2021 @ 02:17 PM
- Tag cleared.
- legacyLoader-arm64_2021-08-18-120614_iMac24.crash 74.3 KB
steve November 17th, 2021 @ 05:06 PM
- Title changed from “check for key comment not executetor if executet can lead to crash” to “check for key comment not executed, if called can lead to crash”
steve November 17th, 2021 @ 05:10 PM
- State changed from “new” to “fixed”
- Assigned user set to “Luke Le”
- Milestone set to “2.7”
https://github.com/GPGTools/GPGPreferences/commit/746d2261112008733...
steve November 17th, 2021 @ 06:48 PM
- State changed from “fixed” to “started”
macOS 11.6.1
GPG Suite 2021.2 (3083n)
- add comment http://gpgtools.org or comment https://gpgtools.org to gpg.conf
- open GPG Suite Preferences
- opens as expected (no crash, that's good)
- however no warning is shown
Support November 27th, 2021 @ 11:36 PM
- Tag set to “”
Assigned to Tender discussion #114757.
steve November 30th, 2021 @ 05:06 PM
- State changed from “started” to “verified”
- Tag cleared.
- Milestone changed from “2.7” to “2.6”
Calling this closed as the crash is gone.

Followup: #121 correctly call and execute check for key comment

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Shared Ticket Bins (Sort)

↓↑ drag 7 Open tickets
↓↑ drag 0 Resolved tickets
↓↑ drag 0 This week's tickets

People watching this ticket

Attachments

legacyLoader-arm64_2021-08-... 74.3 KB

Referenced by

121 correctly call and execute check for key comment This is a followup item to https://gpgtools.lighthouseapp...
121 correctly call and execute check for key comment Testing for the crash fix in #120 came up with following ...

Gpgtools GPGPreferences → 2.6