GPG Tools Installer: Always want to upgrade
Reported by steve | December 27th, 2010 @ 11:20 AM | in 20110322
posted by: Alexander Willner
ported from:
https://github.com/GPGMail/GPGMail/issues/labels/C_Install#issue/222
The installer always want to upgrade every component to a new version. It should be checked whether an update is needed. E.g. when you run the installer the second time it shouldn't install anything since everything is up to date.
Comments and changes to this ticket
-
steve December 27th, 2010 @ 11:22 AM
the following is all comments from GH in a single post:
-
time2ride November 11, 2010 | link | edit | delete Is that really the desired behaviour? IMO the installer should be able to fix broken setups.
-
AlexanderWillner November 11, 2010 | link | edit | delete Ok, fixing broken setups might be a reasonable use case...
-
AlexanderWillner November 11, 2010 | link | edit | delete Moved to 1.3.2. The selection should not be grey if gpg is already installed.
-
time2ride November 12, 2010 | link | edit | delete Thought more about it and the problem is, you have to check not only for gpg but also for all included libs because other packages rely on their existence.
Anyway overwriting the files is no problem.
Conclusion: We should keep it the way it is. -
AlexanderWillner November 12, 2010 | link | edit | delete I dont think so. Imho:
Case 1 (very common): 'which gpg' returns a path. We can assume that the installation works. However, the installer should show the option to reinstall gpg if the user wants to. Case 2 (common): 'which gpg' returns null. The installer should force the user to install gpg. Case 3 (unusual): The gpg installation is broken. See Case 1. -
AlexanderWillner November 13, 2010 | link | edit | delete And the same holds true for all other components that are part of the installer.
-
time2ride November 13, 2010 | link | edit | delete Case 1: we can assume gpg works but not if all libs are installed properly.
How about new versions of gpg. 'which gpg' will still return the path.
As stated before you can just overwrite the files wo. problems.
I can't see the problem here. Or can you precise why you think there is one? -
AlexanderWillner November 14, 2010 | link | edit | delete Consider this: Someone setup a new OS X installation and added gpg2 via fink/port/brew since he likes to manage software this way. Now the installer forces him to install another (uninstallable) gpg version just to use the GPGMail plugin.
This is a problem in my opinion. I definitely want an installer that provides gpg to a user - but only when there is no or a broken installation on the system. -
time2ride November 14, 2010 | link | edit | delete Then he can use the dedicated GPGMail installer. Or we can check for gpg2 as well and make the selection selectable if 'which gpg2' returns something. Isn't GPGMail using gpg2 if both gpg and gpg2 are installed?
-
AlexanderWillner November 14, 2010 | link | edit | delete Why not making it selectable and/or unchecked if any gpg installation was found?
-
-
Mento January 18th, 2011 @ 02:01 PM
- State changed from “open” to “resolved”
- Assigned user set to “time2ride”
-
Alex (via GPGTools) January 20th, 2011 @ 09:53 AM
- Milestone set to “20110322”
- Importance changed from “Medium” to “”
-
steve June 18th, 2015 @ 04:30 PM
- State changed from “resolved” to “released”
- Importance cleared.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
steve