Iterate through all $USER accounts, not for one. Fix typo in gpgmail-postinstall.sh. Set BundleCompatibilityVersion correctly..
Reported by Sierk | January 4th, 2012 @ 05:52 AM | in 2013 05 (closed)
GPGTools_Core/scripts/gpgmail-postinstall.sh (https://github.com/GPGTools/GPGTools_Core/blob/master/scripts/gpgma...:
Iterate through all $USER accounts
----------------------------------
Line 9 (homedir="$HOME/Library/Mail/Bundles/") and corresponding line 19 (_target="$homedir"):
Check for all $USERs, not for the single one, who is logged-in. Iterate through each regular user account via a dscl check to get all $USERs and target them.
For doing so, see also GPGTools_Core/scripts/gpg2-postinstall.sh (https://github.com/GPGTools/GPGTools_Core/blob/master/scripts/gpgmail-postinstall.sh), lines 72ff.
Fix typo:
---------
Line 52 and 53: Typo ("staff", not "Staff" for the group's name):
NOT:
sudo chown $USER:Staff "$HOME/Library/Mail"
sudo chown -R $USER:Staff "$homedir"
BUT:
sudo chown $USER:staff "$HOME/Library/Mail"
sudo chown -R $USER:staff "$homedir"
Set correctly BundleCompatibilityVersion:
-----------------------------------------
Line 83: should have a version-check, which major version of MacOSX is used and then the apropriate BundleCompatibilityVersion set:
if (MacOSX 10.7.x, aka Lion) then
defaults write "$domain" BundleCompatibilityVersion -int 5
elif (MacOSX 10.6.x, aka Snow Leopard) then
defaults write "$domain" BundleCompatibilityVersion -int 4
elif (MacOSX 10.5.x, aka Leopard) then
defaults write "$domain" BundleCompatibilityVersion -int 3
fi
Comments and changes to this ticket
-
Alex (via GPGTools) January 4th, 2012 @ 08:03 AM
- Assigned user set to “Alex (via GPGTools)”
- State changed from “new” to “open”
Wow - thank you very much for this constructive feedback! Would you mind forking the according repository within GitHub and pushing a change request? This way we can both be sure that everything will get changed as expected.
-
-
Alex (via GPGTools) January 4th, 2012 @ 08:07 AM
- State changed from “open” to “waiting”
- Milestone set to “20120317”
- Importance changed from “” to “”
-
Alex (via GPGTools) January 17th, 2012 @ 04:03 PM
Almost done: https://github.com/GPGTools/GPGTools_Core/commit/ac9ea7f88e89d78be9...
Question: "Iterate through all $USER accounts": this would assume that the current user can write into all home directories - i.e. the admin. Isn't /Library/Mail/Bundles a better place for installing a system wide bundle?
-
Alex (via GPGTools) March 1st, 2012 @ 06:41 PM
- Milestone changed from “20120317” to “2013 05”
- Importance changed from “” to “High”
-
steve February 1st, 2013 @ 06:56 PM
- State changed from “waiting” to “released”
- Importance cleared.
-
steve February 1st, 2013 @ 06:57 PM
- State changed from “released” to “fixed”
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
steve