#108 ✓released
Sierk

Iterate through all $USER accounts, not for one. Fix typo in gpgmail-postinstall.sh. Set BundleCompatibilityVersion correctly..

Reported by Sierk | January 4th, 2012 @ 05:52 AM | in 2013 05 (closed)

GPGTools_Core/scripts/gpgmail-postinstall.sh (https://github.com/GPGTools/GPGTools_Core/blob/master/scripts/gpgma...:

Iterate through all $USER accounts
----------------------------------

Line 9 (homedir="$HOME/Library/Mail/Bundles/") and corresponding line 19 (_target="$homedir"):
Check for all $USERs, not for the single one, who is logged-in. Iterate through each regular user account via a dscl check to get all $USERs and target them.
For doing so, see also GPGTools_Core/scripts/gpg2-postinstall.sh (https://github.com/GPGTools/GPGTools_Core/blob/master/scripts/gpgmail-postinstall.sh), lines 72ff.



Fix typo:
---------

Line 52 and 53: Typo ("staff", not "Staff" for the group's name):

NOT:
sudo chown $USER:Staff "$HOME/Library/Mail"
sudo chown -R $USER:Staff "$homedir"

BUT:
sudo chown $USER:staff "$HOME/Library/Mail"
sudo chown -R $USER:staff "$homedir"



Set correctly BundleCompatibilityVersion:
-----------------------------------------

Line 83: should have a version-check, which major version of MacOSX is used and then the apropriate BundleCompatibilityVersion set:

if (MacOSX 10.7.x, aka Lion) then
defaults write "$domain" BundleCompatibilityVersion -int 5
elif (MacOSX 10.6.x, aka Snow Leopard) then
defaults write "$domain" BundleCompatibilityVersion -int 4
elif (MacOSX 10.5.x, aka Leopard) then
defaults write "$domain" BundleCompatibilityVersion -int 3
fi

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Shared Ticket Bins

People watching this ticket

Pages